refactor: Clientbuilder accept backoffconfig #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
requested changes
Jul 31, 2023
src/backoff.rs
Outdated
| /// | ||
| /// See <https://aws.amazon.com/blogs/architecture/exponential-backoff-and-jitter/> | ||
| #[derive(Debug, Clone)] | ||
| #[derive(Debug, Clone, Copy)] |
There was a problem hiding this comment.
I would prefer to NOT have this Copy so we can extend this later. Copy should only be used for very small types (IIRC rustc triggers this up to 256 bytes).
If you have trouble w/ clippy/rustc complaining about a missing copy impl, stick an #[allow(missing_copy_implementations)] to this type.
There was a problem hiding this comment.
I'm not sure if this creates any other form of violation, however, I had to switch to using Arc for the BackoffConfig just for simplicity and also to avoid having to introduce complexity with using lifetimes.
crepererum
approved these changes
Aug 2, 2023
crepererum
changed the title
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your proposed changes here.
This changes will allow users to configure backoff/retry to their liking. This is also one of a 2 part changes (other still in progress) in an attempt to also allow a form of termination and not try forever especially without informing the user of the progress.