fix: (potential) metadata cache invalidation race #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under certain conditions it MAY happen that metadata cache invalidation races, e.g.: | Thread 1 | Thread 2 | | ------------ | ------------ | | get metadata | | | | get metadata | | invalidate | | | get metadata | | | | invalidate | Here the 2nd invalidation is unnecessary. It's not a correctness issue, but we throw away cached data that is perfectly fine. To work around this, we now track a "generation" for data that we get from the metadata cache and check this during invalidation requests. Ref #62. (not closing, need to do the same for the broker connection cache)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain conditions it MAY happen that metadata cache invalidation races, e.g.:
Here the 2nd invalidation is unnecessary. It's not a correctness issue, but we throw away cached data that is perfectly fine.
To work around this, we now track a "generation" for data that we get from the metadata cache and check this during invalidation requests.
Ref #62. (not closing, need to do the same for the broker connection cache)