feat: support pre-warming PartitionClient #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a refresh_leader() method to force the PartitionClient through the discovery process. This will ensure a cached connection to the leader is (likely) already established by the time the first produce() call is issued, preventing the first produce() calls (multiple of which may be queued up on the discovery mutex) from experiencing excessively high latency.
Change the Client::partition_client() constructor to always perform leader detection and establish a connection to the broker immediately, instead of differing the work until the first produce() call. This eliminates the unusually high latency of the first produce() call. BREAKING CHANGE: PartitionClient constructor is now async
|
I have made the breaking change proposed in the description - now all users will have a fully-primed |
crepererum
reviewed
Aug 11, 2022
Adds a retry loop (w/ backoff) over the leader discover when initialising a PartitionClient.
domodwyer
force-pushed
the
dom/pre-warm
branch
from
27797c4 to
e060f60
Compare
crepererum
approved these changes
Aug 11, 2022
domodwyer
added a commit
that referenced
this pull request
Aug 11, 2022
PR #165 added leader discovery at initialisation time and intended to also cache the broker connection but called the wrong func. This commit calls get() which establishes & caches the broker connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes a method that can be used to drive leader discovery before the first call to
produce()on aPartitionClient. This allows us to "pre-warm" the cached broker connection to the leader and avoid doing it when we send through the first write.Ideally we would do this automatically when initialising the
PartitionClient, but that would be a breaking change as the constructor would need to become async - happy to change it if a breaking change is acceptable 👍I wasn't really sure how to test this 🤷
feat: support pre-warming PartitionClient (b612f08)
refactor: pre-warm PartitionClient connection (387a96d)
refactor: retry failed leader discovery (e060f60)