feat: extend ServerError with helpful data
#160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
force-pushed
the
crepererum/issue148
branch
from
9dd1c6b to
a5a3fbf
Compare
tustvold
reviewed
Aug 1, 2022
| payload: Option<ServerErrorPayload>, | ||
|
|
||
| /// Flags if the error was generated by the client to simulate some server behavior or workaround a bug. | ||
| is_virtual: bool, |
There was a problem hiding this comment.
What is the intended use-case for this?
There was a problem hiding this comment.
debugging mostly
| protocol_error: ProtocolError, | ||
|
|
||
| /// Server message provided by the broker, if any. | ||
| error_message: Option<String>, |
There was a problem hiding this comment.
I wonder if this could be merged into ServerErrorResponse?
There was a problem hiding this comment.
I think most newer Kafka messages now have an error code and a human-readable string (i.e. this message). The response is mostly what else we could extract. So yeah, we could merge it but I guess the resulting enum will rather unhelpful because in many cases we don't have anything else than the error message.
|
@tustvold PTAL |
tustvold
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #159.Closes #148.