refactor: speed up IO #156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. refactor: use sync lock in request path
2. refactor: avoid thread/task bouncing when sending data
The problem with spawning tasks (or a MPSC construction) is that tokio
will likely execute the task in another thread and requires additional
futex syscalls for synchronization. When sending data we were wrapping
the sending task to prevent cancellation. However cancellation is a
rather unlikely event (unhappy path) and we should only pay for it when
it is really needed.