fix: use compact arrays where needed #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compact array representations were introduced at the same time as compact strings and tagged fields. For arrays with versioned structures we already use these. For primitive arrays however we did not use them yet. The only message where this applies is CreateTopics and the broker didn't seem to care that we've messed up the serialization of this one field. Compact arrays might be helpful for other message types as well, so this is both a fix and some feature work.
tustvold
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compact array representations were introduced at the same time as
compact strings and tagged fields. For arrays with versioned structures
we already use these. For primitive arrays however we did not use them
yet. The only message where this applies is CreateTopics and the broker
didn't seem to care that we've messed up the serialization of this one
field.
Compact arrays might be helpful for other message types as well, so this
is both a fix and some feature work.