fix: TLS feature flag #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds missing cfg(tls) annotations to code blocks that require it, allowing cargo check --all-targets to pass.
Adds --all-targets to the "no default features" build, which causes it to validate the flags used in #[cfg(test)] gated blocks too.
crepererum
approved these changes
Mar 29, 2022
| async fn connect( | ||
| &self, | ||
| _tls_config: Option<Arc<rustls::ClientConfig>>, | ||
| _tls_config: TlsConfig, |
There was a problem hiding this comment.
I was briefly wondering why this code compiled before, but it turns out that this is test code as well and therefore wasn't checked via cargo build --no-default-features. Good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parts of the code were referencing types behind feature flags, and CI wasn't catching it - this PR corrects both.
fix: missing TLS feature gates (1c0eb13)
ci: check all targets with no features (04f6863)