Skip to content

fix: Remove as conversions in protocol/record.rs #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2022
Merged

fix: Remove as conversions in protocol/record.rs #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/protocol/record.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ where
fn read(reader: &mut R) -> Result<Self, ReadError> {
// length
let len = Varint::read(reader)?;
let len = usize::try_from(len.0).map_err(|e| ReadError::Malformed(Box::new(e)))?;
let reader = &mut reader.take(len as u64);
let len = u64::try_from(len.0).map_err(|e| ReadError::Malformed(Box::new(e)))?;
let reader = &mut reader.take(len);

// attributes
Int8::read(reader)?;
Expand Down Expand Up @@ -399,7 +399,7 @@ where

// check if there is any trailing data because this is likely a bug
let bytes_read = data.position();
let bytes_total = data.into_inner().len() as u64;
let bytes_total = u64::try_from(data.into_inner().len()).map_err(ReadError::Overflow)?;
let bytes_left = bytes_total - bytes_read;
if bytes_left != 0 {
return Err(ReadError::Malformed(
Expand Down