fix: make Messenger::request cancellation-safe
#115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids that we write partial messages to the underlying TCP/TLS connection and mess up message framing. This will nearly always lead to broker-side errors and the broker closes the connection. Fixes #103.
tustvold
approved these changes
Mar 7, 2022
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_cancel_request() { |
There was a problem hiding this comment.
I think this test would be easier to follow if the loops were broken up into separate functions, but it's fine as is also
src/messenger.rs
Outdated
| // simulated broker, just reads messages and answers w/ "api versions" responses | ||
| let handle_broker = tokio::spawn(async move { | ||
| for correlation_id in 0.. { | ||
| rx_back.read_message(1_000).await.unwrap(); |
There was a problem hiding this comment.
Could possibly check that the message is an ApiVersions request
crepererum
force-pushed
the
crepererum/issue103
branch
from
2fdfca0 to
db79dba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids that we write partial messages to the underlying TCP/TLS
connection and mess up message framing. This will nearly always lead to
broker-side errors and the broker closes the connection.
Fixes #103.