fix: ensure Java interopt #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
force-pushed
the
crepererum/java_interopt
branch
from
db8ca1d to
67fa4ce
Compare
The only issue found by this is that we were not able to read Snappy-compressed data produced by Java clients, because Java uses its own weird framing format. Funnily Java clients can read the Snappy data what we produce. This is also in line with the rdkafka implemention (they can consume the "normal" and the special "Java" format but only produce the "normal" one).
Co-authored-by: Raphael Taylor-Davies <[email protected]>
crepererum
force-pushed
the
crepererum/java_interopt
branch
from
aae7555 to
47f2c12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only issue found by this is that we were not able to read
Snappy-compressed data produced by Java clients, because Java uses its
own weird framing format. Funnily Java clients can read the Snappy data
what we produce. This is also in line with the rdkafka implemention
(they can consume the "normal" and the special "Java" format but only
produce the "normal" one).
Closes #98.