Skip to content

feat: extend watermark API to get both low/high offset #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2022
Merged

feat: extend watermark API to get both low/high offset #100

merged 1 commit into from
Feb 14, 2022

Conversation

crepererum
Copy link
Collaborator

Based on #99.

@crepererum crepererum force-pushed the crepererum/get_offset branch from 3430959 to 14c8a83 Compare February 14, 2022 09:35
@crepererum crepererum marked this pull request as ready for review February 14, 2022 09:36
tustvold
tustvold approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this would only be useful for reporting, as the earliest offset may change before a subsequent fetch records call, leading to OffsetOutOfRange

src/client/partition.rs
fn build_list_offsets_request(partition: i32, topic: &str) -> ListOffsetsRequest {
fn build_list_offsets_request(partition: i32, topic: &str, at: OffsetAt) -> ListOffsetsRequest {
let timestamp = match at {
OffsetAt::Earliest => -2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪄

@crepererum
Copy link
Collaborator Author

I'm guessing this would only be useful for reporting, as the earliest offset may change before a subsequent fetch records call, leading to OffsetOutOfRange

This is true for both offsets, I'll add a note/warning to the method.

@crepererum crepererum force-pushed the crepererum/get_offset branch from 14c8a83 to 978f31f Compare February 14, 2022 09:47
@crepererum
Copy link
Collaborator Author

I'm guessing this would only be useful for reporting, as the earliest offset may change before a subsequent fetch records call, leading to OffsetOutOfRange

This is true for both offsets, I'll add a note/warning to the method.

done

@crepererum crepererum added the automerge Instruct kodiak to merge the PR label Feb 14, 2022
@kodiakhq kodiakhq bot merged commit 7c74d43 into main Feb 14, 2022
@crepererum crepererum deleted the crepererum/get_offset branch February 16, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@tustvold tustvold tustvold approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
automerge Instruct kodiak to merge the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crepererum @tustvold