Could async be removed from these functions?

[segeljakt]

There are functions that do not contain async code. Currently, I need to use futures::executor::block_on to execute these two functions.

• rskafka/src/client/mod.rs

  Lines 113 to 115 in bd61405

  	pub async fn controller_client(&self) -> Result<ControllerClient> {
  	Ok(ControllerClient::new(Arc::clone(&self.brokers)))
  	}

• rskafka/src/client/controller.rs

  Lines 30 to 37 in bd61405

  	impl ControllerClient {
  	pub(super) fn new(brokers: Arc<BrokerConnector>) -> Self {
  	Self {
  	brokers,
  	backoff_config: Default::default(),
  	current_broker: Mutex::new(None),
  	}
  	}

• rskafka/src/client/mod.rs

  Lines 118 to 128 in bd61405

  	pub async fn partition_client(
  	&self,
  	topic: impl Into<String> + Send,
  	partition: i32,
  	) -> Result<PartitionClient> {
  	Ok(PartitionClient::new(
  	topic.into(),
  	partition,
  	Arc::clone(&self.brokers),
  	))
  	}

Could async be removed for these two or is there a reason it is used?

[crepererum]

I think the reasons where that someone thought that calling functions might involve some IO in the future, but that's currently not the case. I therefore think we can just make them sync for now.