Skip to content

Convert as conversions to From/TryFrom #101

@crepererum

Description

@crepererum

The as conversions in our protocol code our quite dangerous and I think we might have a few integer overflow bugs in there. In general I think we should replace all as conversions with From and TryFrom to make it clear if the conversion can fail or not. There is also a clippy lint as_conversions which should be added to our code base to prevent regressions.

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions