-
Notifications
You must be signed in to change notification settings - Fork 155
feat(contrib/qxip): add contrib/qxip/hash package #5355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmangani Looks great. Some minor doc suggestions, but that's it. Thanks!
Thanks @sanderson for the review and for the doc corrections! |
@lmangani Did you copy the code for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to understand how/if we can import CityHash
in the normal way.
Just following the contribution guidelines
Edit: Generally speaking, it would make sense to import the library if it has any other applications present of future and think having cityhash64/128 in Flux would be quite useful on top of xxhash for high collision use cases, but since this is just a sideload contrib we had no such ambition. Curious to see what you guys think - Thanks for the time! |
@lmangani This makes sense. Thanks for the rationale there. It's been a while since I've looked at the contribution guidelines. |
Thanks! Shall CityHash or any other hashing library become part of the Flux core, I'll update the code to use it/them. |
This PR adds
contrib/qxip/hash
package exposing basic go hashing functions to flux scripts.Included readme explains the functionality.
This proposal might require adaptions and is very much intended for discussion and extension as core maintainers see fit.
Done checklist: