Skip to content

use copy-webpack-plugin to deliver all static assets #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2021
Merged

use copy-webpack-plugin to deliver all static assets #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1034ba6
use copy-webpack-plugin to deliver all static assets. this also works…
aruniverse Apr 15, 2021
5f5846b
bump ver
aruniverse Apr 15, 2021
1347d9a
pickup new CopyStaticAssetsPlugin from 2.16.1
aruniverse May 27, 2021
a795cca
forgot to remove old CopyWebpackPlugin
aruniverse May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-scripts/config/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ const FilterWarningsPlugin = require('webpack-filter-warnings-plugin');

const {
BanBackendImportsPlugin,
CopyStaticAssetsPlugin,
IModeljsLibraryExportsPlugin,
CopyBentleyStaticResourcesPlugin,
} = require('@bentley/webpack-tools-core');

// iModel.js change to support using the fast-sass-loader instead of sass-loader.
Expand Down Expand Up @@ -412,7 +412,7 @@ module.exports = function(webpackEnv) {
},
plugins: [
// Throw an error if @bentley/imodeljs-backend or src/backend/... files are imported.
new BanBackendImportsPlugin(path.join(paths.appSrc, "backend")),
new BanBackendImportsPlugin(path.join(paths.appSrc, 'backend')),
// Adds support for installing with Plug'n'Play, leading to faster installs and adding
// guards against forgotten dependencies and such.
PnpWebpackPlugin,
Expand Down Expand Up @@ -696,9 +696,9 @@ module.exports = function(webpackEnv) {
new IModeljsLibraryExportsPlugin(),

// NOTE: iModel.js specific plugin to copy a set of static resources from the node_modules
// directory of each dependent package into the 'lib/public' directory.
// directory of each dependent package into the 'build/public' directory.
// Used for resources such as locales, which are defined by each consuming package.
new CopyBentleyStaticResourcesPlugin(['public'], true),
new CopyStaticAssetsPlugin({}),

// NOTE: FilterWarningsPlugin is used to ignore warning coming from sourcemaps
new FilterWarningsPlugin({ exclude: /Failed to parse source map/ }),
Expand Down
4 changes: 2 additions & 2 deletions packages/react-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bentley/react-scripts",
"version": "3.4.10",
"version": "3.4.11",
"description": "iModel.js configuration and scripts for Create React App.",
"repository": {
"type": "git",
Expand Down Expand Up @@ -29,7 +29,7 @@
"types": "./lib/react-app.d.ts",
"dependencies": {
"@babel/core": "7.9.0",
"@bentley/webpack-tools-core": "^2.0.0",
"@bentley/webpack-tools-core": "^2.16.1",
"@svgr/webpack": "4.3.3",
"@typescript-eslint/eslint-plugin": "^4.1.1",
"@typescript-eslint/parser": "^4.1.1",
Expand Down