Skip to content

fix(web): enhance face tagging confirmation and fix #18605 #18610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2025

Conversation

dvbthien
Copy link
Contributor

Description

This PR enhances the face tagging functionality with improved internationalization support, fixes UI accessibility issues in checkbox components, and performs translation cleanup.

Fixes #18605

How Has This Been Tested?

I've verified that the checkbox label isn't duplicated, and the tagging notification is functioning as expected

Screenshots (if appropriate)

Screenshot 2025-05-25 at 21 57 26

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

@alextran1502 alextran1502 merged commit d22fb2d into immich-app:main May 25, 2025
49 of 50 checks passed
@NicholasFlamy
Copy link
Contributor

Thanks!

@dvbthien dvbthien deleted the web/improve-i18n-and-ui branch May 29, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transcoding configuration has doubled labels
3 participants