Support .plugged in user:// #40
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems there continues to be issues with Godot parsing plugins even within the addons folder and even with .gdignore (see #37 (comment), #32 ). gd-plug already supports addons outside of the project directory (eg
res://../.pluggedworks fine) but it does not support.pluggedin theuser://directory, since Godot has built-in protection against this in DirAccess. Since this directory is kept in-sync with projects for other engine uses, it seems like a natural place to keep.plugged(although certainly less preferable than easiily visible in the project folder, but at least until Godot plays nice with that it's a decent workaround)This is a draft pull request to support
user://.plugged, it is only lightly tested and has two temporary changes included to facilitate testing this functionality:user://.pluggedSeems to work great so far, and no errors from Godot parsing any files it shouldn't.
There's another approach that would work - to globalize all paths before opening anything, but I think this way seems a bit safer.
I would like to merge this (with those temporary changes removed) as well as #37 which means we'll support .plugged everywhere, then after that we can figure out how/if we want to migrate its default location.