Use <database> tag for compatibility sake #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revert open/close tag from <database2> to <database> for compatibility with all pages in installed dokuwiki
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
Thank you for keeping this great plugin running and up to date with current DokuWiki.
However, the change form
<database>to<database2>introduced in commit dd860181afdb47091e2a20639f48a6e70dea3bfe (or was it c89678e704eab1a5411bc57dafe94811c0fdad7d) simply breaks the existing pages.On the other side, there is this idea of not conflicting with the database plugin. This plugin has not been maintained for almost 10 years, and was already incompatible with DW 2008-05-05. As of today, once installed it will simply break the entire wiki : all non cached page render as blank page, as well as the admin panel. In fact, it cannot load because of syntax errors ! So it is questionable wether not conflicting with it matters.
Please consider going back to
<database>for compatibility reasons.