Support usage of relative urls to set database on the default host #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a real-world use-case in node-postgres where the host name was being set using an environment variable, but we needed to change the database in code. node-postgres was being wrapped in other code that we could not edit for beurocratic reasons. This code prevented us from passing config objects (i.e. forced us to pass a connection 'string'). The current code assumes that the pathname returned by nodejs will always have a leading '/'. This is true for fully qualified urls, but NOT true for relative urls. This caused pg-connection-string to return a database config object where the database was missing it's first character. There are work-arounds, but it seems like something that is easily supported.