Skip to content

Conversation

brianch
Copy link
Contributor

@brianch brianch commented Jan 31, 2024

This fixes #2222.

The sysinfo total_memory() called by Iced here returns the value in bytes and not kylobytes as the documentation in the Information struct previously said (the same for the process' memory usage).

@hecrj hecrj added this to the 0.12 milestone Feb 2, 2024
@hecrj hecrj added bug Something isn't working shell fix labels Feb 2, 2024
@hecrj hecrj force-pushed the fix-sysinfo-example branch 2 times, most recently from 29d374e to 790ac77 Compare February 2, 2024 15:01
Fix the documentation of the Information struct, and the example
system_information that uses it.

Co-authored-by: =?UTF-8?q?Ahmet=20Kaan=20G=C3=9CM=C3=9C=C5=9E?= <[email protected]>
@hecrj hecrj force-pushed the fix-sysinfo-example branch from 790ac77 to 701bf22 Compare February 2, 2024 15:02
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇

@hecrj hecrj enabled auto-merge February 2, 2024 15:04
@hecrj hecrj merged commit 1049fbb into iced-rs:master Feb 2, 2024
@brianch brianch deleted the fix-sysinfo-example branch February 2, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong system information
2 participants