fix no streams for newly published rumble videos #1408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iawia002
reviewed
Apr 18, 2025
extractors/rumble/rumble.go
Outdated
| Q2161 struct{ streamInfo } `json:"2161"` | ||
| } | ||
|
|
||
| type tarVideoQualities struct { |
Owner
There was a problem hiding this comment.
This is unused, can we remove this?
Contributor
Author
There was a problem hiding this comment.
Yes sorry I forgot to delete that. It was my first attempt at the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had an issue where newly uploaded videos had no streams. The json file returned has a new section in that is called tar, its a m3u8 files for each resolution that include chunks of a mp2t file.
Updated the library to correctly get the new type of stream