Skip to content

Conversation

bkleiner
Copy link
Collaborator

@bkleiner bkleiner commented Sep 10, 2025

the 9v on the H7 was missed during initial target creation, externally pulled high.
adds defaults for the USR aux switches on the all lucid h7 fcs.
adds timer assigments for the mini, as the esc is hard soldered.

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
⚡ Recommended focus areas for review

Flag Semantics

Verify that using PINIO_FLAGS_INVERTED matches the actual hardware behavior for PC13 (external pull-up, active-low enable). Confirm the runtime logic and UI mapping expect an inverted control to avoid reversed switch behavior.

#define PINIO3_PIN                  PC13
#define PINIO3_FLAGS                PINIO_FLAGS_INVERTED
Pin Availability

Ensure PC13 is not used elsewhere (e.g., LED, RTC, or system functions) and that it supports GPIO output with the needed speed/drive for the 9V enable circuit on this target.

#define PINIO3_PIN                  PC13
#define PINIO3_FLAGS                PINIO_FLAGS_INVERTED
Box Mapping Consistency

Adding permanentId[2] for USER3 requires that firmware and UI expect three PINIO boxes; verify array bounds, feature enablement, and that PINIO3 presence in target.h aligns with this mapping.

pinioBoxConfigMutable()->permanentId[0] = BOX_PERMANENT_ID_USER1;
pinioBoxConfigMutable()->permanentId[1] = BOX_PERMANENT_ID_USER2;
pinioBoxConfigMutable()->permanentId[2] = BOX_PERMANENT_ID_USER3;
beeperConfigMutable()->pwmMode = true;

@bkleiner bkleiner force-pushed the add-lucid-h7-9ven branch 2 times, most recently from 82547a6 to 7190092 Compare September 10, 2025 11:41
@bkleiner bkleiner merged commit dc2cf05 into iNavFlight:maintenance-8.x.x Sep 10, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant