Skip to content

Conversation

Scavanger
Copy link
Contributor

@Scavanger Scavanger commented Sep 6, 2025

User description

Mac SITL CI should work again.


PR Type

Bug fix


Description

This description is generated by an AI tool. It may have inaccuracies

  • Remove cmake and ninja from Mac SITL CI dependencies

  • Fix Mac SITL CI build issues


Diagram Walkthrough

flowchart LR
  A["Mac SITL CI"] -- "remove dependencies" --> B["cmake, ninja removed"]
  B --> C["CI fixed"]
Loading

File Walkthrough

Relevant files
Bug fix
ci.yml
Remove cmake ninja dependencies from Mac CI                           

.github/workflows/ci.yml

  • Remove cmake and ninja from brew install command
  • Keep only ruby as dependency for Mac SITL build
+1/-1     

Copy link

qodo-merge-pro bot commented Sep 6, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
⚡ Recommended focus areas for review

Missing Build Tools

Removing cmake and ninja may break builds if the project or its dependencies still require them on macOS runners. Validate that these tools are not needed by the SITL build scripts or any transitive steps.

- uses: actions/checkout@v4
- name: Install dependencies
  run: |
    brew install ruby

- name: Setup environment
Homebrew Update Step

Consider adding brew update before installs to avoid failures due to outdated formulae on GitHub macOS runners.

- name: Install dependencies
  run: |
    brew install ruby

- name: Setup environment
Minimal Dependency Pinning

Installing unpinned ruby can lead to nondeterministic CI behavior if Homebrew updates; consider pinning a version or using actions/setup-ruby to manage Ruby reliably.

- name: Install dependencies
  run: |
    brew install ruby

- name: Setup environment

Copy link

qodo-merge-pro bot commented Sep 6, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Prefer Homebrew Ruby via PATH

Ensure the brewed Ruby is actually used by subsequent steps by adding its bin
directory to the PATH via $GITHUB_PATH. Otherwise, the system Ruby may be picked
up, leading to gem/bundler incompatibilities and CI failures.

.github/workflows/ci.yml [189]

 brew install ruby
+echo "$(brew --prefix)/opt/ruby/bin" >> "$GITHUB_PATH"
  • Apply / Chat
Suggestion importance[1-10]: 7

__

Why: This is a valid and important improvement to ensure that the newly installed Ruby version is used by subsequent steps, preventing potential CI failures due to version mismatches.

Medium
  • More

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant