Skip to content

Conversation

DusKing1
Copy link
Contributor

@DusKing1 DusKing1 commented Sep 4, 2025

User description

Enable support for the ICM42605 IMU on the SKYSTARSH743HD target.


PR Type

Enhancement


Description

This description is generated by an AI tool. It may have inaccuracies

  • Enable ICM42605 IMU support for SKYSTARSH743HD target

  • Add USE_IMU_ICM42605 configuration define


Diagram Walkthrough

flowchart LR
  A["SKYSTARSH743HD target"] --> B["IMU Support"]
  B --> C["BMI270 (existing)"]
  B --> D["ICM42605 (new)"]
Loading

File Walkthrough

Relevant files
Enhancement
target.h
Enable ICM42605 IMU support                                                           

src/main/target/SKYSTARSH743HD/target.h

  • Add USE_IMU_ICM42605 define to enable ICM42605 IMU support
+1/-0     

enable support for the ICM42605 IMU on the SKYSTARSH743HD target.
Copy link

qodo-merge-pro bot commented Sep 4, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
⚡ Recommended focus areas for review

Configuration Consistency

Adding USE_IMU_ICM42605 alongside USE_DUAL_GYRO and USE_IMU_BMI270 may require corresponding hardware descriptors (bus/CS/align) for the second IMU; verify that the target has proper definitions for ICM42605 (bus, CS pin, orientation) and that dual-IMU selection logic won’t conflict.

#define USE_DUAL_GYRO
#define USE_TARGET_IMU_HARDWARE_DESCRIPTORS
#define USE_IMU_BMI270
#define USE_IMU_ICM42605
// *****IMU1 BMI270 ON  SPI4 **************
#define IMU1_ALIGN              CW0_DEG
#define IMU1_SPI_BUS            BUS_SPI4
#define IMU1_CS_PIN             PE11
Build Guarding

Ensure the codebase has ICM42605 driver and that enabling USE_IMU_ICM42605 here won’t cause unresolved references if the driver or descriptor is not compiled for this target; consider wrapping with appropriate feature checks.

#define USE_IMU_BMI270
#define USE_IMU_ICM42605
// *****IMU1 BMI270 ON  SPI4 **************

Copy link

qodo-merge-pro bot commented Sep 4, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

@DusKing1
Copy link
Contributor Author

DusKing1 commented Sep 4, 2025

CI failed but I don't think my change made it.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant