Skip to content

Remove snyk. #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2022
Merged

Remove snyk. #374

merged 3 commits into from
Oct 24, 2022

Conversation

tyroneyu
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Remove snyk, it is not working in our org. Replace with owasp dependency check.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

rely on CI.

Checklist:

  • My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@tyroneyu
Copy link
Contributor Author

tyroneyu commented Oct 21, 2022

I don't know why the snyk-scan is still being run.

Does the PR need to get merged in before the CI is changed? If so, it feels like a catch-22

@tyroneyu tyroneyu changed the title Remove snyk, use owasp dependency check Remove snyk. Oct 24, 2022
@tyroneyu tyroneyu merged commit c981dfc into main Oct 24, 2022
@tyroneyu tyroneyu deleted the snyk branch October 24, 2022 16:15
shashank11p pushed a commit that referenced this pull request Feb 24, 2023
* Remove snyk, use owasp dependency check

* Add Makefile option and CI job

* Comment out owasp dependency check and implement in separate PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants