Skip to content

chore: fix inaccurate comment for MergeWithPlurality function #5362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pfi79 merged 1 commit into from
Dec 10, 2025
Merged

chore: fix inaccurate comment for MergeWithPlurality function #5362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/policies/inquire/merge.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ type comparablePrincipalSetPair struct {
containing ComparablePrincipalSet
}

// EnsurePlurality returns a ComparablePrincipalSet such that plurality requirements over
// the contained ComparablePrincipalSet in the comparablePrincipalSetPair hold
// MergeWithPlurality returns a ComparablePrincipalSet that merges the contained and containing
// ComparablePrincipalSets in the comparablePrincipalSetPair while satisfying plurality requirements
func (pair comparablePrincipalSetPair) MergeWithPlurality() ComparablePrincipalSet {
var principalsToAdd []*ComparablePrincipal
used := make(map[int]struct{})
Expand Down