Feature/fabric optimizations #5361
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukanyaByteSavy
force-pushed
the
feature/fabric-optimizations
branch
from
ad69170 to
b14f952
Compare
Author
|
Hello, this PR is from a fork. |
SukanyaByteSavy
force-pushed
the
feature/fabric-optimizations
branch
3 times, most recently
from
c353a1a to
0986757
Compare
Optimizes GetPvtDataByBlockNum by caching purge markers (N+1 fix) and adds regression test for FAB-15704. Signed-off-by: Sukanya Patnaik <[email protected]>
SukanyaByteSavy
force-pushed
the
feature/fabric-optimizations
branch
from
0986757 to
d323148
Compare
Member
|
@SukanyaByteSavy Your change is failing the basic checks step of the build. It might be worth running |
Author
@bestbeforetoday thanks for the advice ... will do that rightaway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary: Private Data Enhancements and Performance Optimization
New Test Case for Rollback and Data Revival
Test Implemented: TestRollbackKVLedgerPvtDataRevival
Location: core/ledger/kvledger/tests/rollback_pvtdata_revival_test.go
Scenario Verified: Ensures private data is correctly accessible (revived) when the ledger is rolled back to a block height before the data's purging block.
Gap Addressed: Fills an integrity testing gap identified in rollback_test.go.
Cleanup: The stale TODO regarding FAB-15704 was removed.
Efficient Private Data Retrieval
Component: core/ledger/pvtdatastorage
Issue: Identified an N+1 database query inefficiency in GetPvtDataByBlockNum. retrieveLatestPurgeKeyCollMarkerHt was repeatedly called for every key in the same collection.
Fix: Introduced a local cache (purgeMarkerCache) within the retrieval loop to store and reuse purge markers.
Impact: Significantly reduces DB reads, changing the retrieval scaling from O(N) per key to O(1) per collection.
✅ Verification
Successful addition and execution of TestRollbackKVLedgerPvtDataRevival in core/ledger/kvledger/tests.
Verified compilation and logic of the pvtdatastorage optimization.