Fixes #5001

core/chaincode/handler.go

@@ -733,6 +733,17 @@ func (h *Handler) HandleGetStateMetadata(msg *pb.ChaincodeMessage, txContext *Tr
 
 // Handles query to ledger to rage query state
 func (h *Handler) HandleGetStateByRange(msg *pb.ChaincodeMessage, txContext *TransactionContext) (*pb.ChaincodeMessage, error) {
+	// Defer panic recovery
+	defer func() {
+		if r := recover(); r != nil {
+			chaincodeLogger.Errorf("Panic in HandleGetStateByRange: %v", r)
+			// Clean up any query context that may have been created
+			if txContext != nil {
+				txContext.CleanupQueryContext("")
+			}
+		}
+	}()
+
 	getStateByRange := &pb.GetStateByRange{}
 	err := proto.Unmarshal(msg.Payload, getStateByRange)
 	if err != nil {
@@ -750,6 +761,12 @@ func (h *Handler) HandleGetStateByRange(msg *pb.ChaincodeMessage, txContext *Tra
 	isPaginated := false
 	namespaceID := txContext.NamespaceID
 	collection := getStateByRange.Collection
+
+	// Validate start and end keys
+	if getStateByRange.StartKey == "" && getStateByRange.EndKey == "" {
+		return nil, errors.New("start key and end key must not both be empty")
+	}
+
 	if isCollectionSet(collection) {
 		if txContext.IsInitTransaction {
 			return nil, errors.New("private data APIs are not allowed in chaincode Init()")
@@ -767,14 +784,29 @@ func (h *Handler) HandleGetStateByRange(msg *pb.ChaincodeMessage, txContext *Tra
 				startKey = metadata.Bookmark
 			}
 		}
+
+		// Validate page size
+		if metadata.PageSize < 1 {
+			return nil, errors.New("page size must be greater than zero")
+		}
+
 		rangeIter, err = txContext.TXSimulator.GetStateRangeScanIteratorWithPagination(namespaceID,
 			startKey, getStateByRange.EndKey, metadata.PageSize)
 	} else {
 		rangeIter, err = txContext.TXSimulator.GetStateRangeScanIterator(namespaceID, getStateByRange.StartKey, getStateByRange.EndKey)
 	}
+
 	if err != nil {
+		// Clean up any resources if error occurs
+		txContext.CleanupQueryContext(iterID)
 		return nil, errors.WithStack(err)
 	}
+
+	if rangeIter == nil {
+		txContext.CleanupQueryContext(iterID)
+		return nil, errors.New("range query iterator is nil")
+	}
+
 	txContext.InitializeQueryContext(iterID, rangeIter)
 
 	payload, err := h.QueryResponseBuilder.BuildQueryResponse(txContext, rangeIter, iterID, isPaginated, totalReturnLimit)

core/ledger/kvledger/txmgmt/statedb/stateleveldb/stateleveldb.go

@@ -8,6 +8,7 @@ package stateleveldb
 
 import (
 	"bytes"
+	"fmt"
 
 	"github.com/hyperledger/fabric-lib-go/common/flogging"
 	"github.com/hyperledger/fabric/common/ledger/dataformat"
@@ -164,10 +165,28 @@ func (vdb *versionedDB) GetStateRangeScanIteratorWithPagination(namespace string
 	if endKey == "" {
 		dataEndKey[len(dataEndKey)-1] = lastKeyIndicator
 	}
-	dbItr, err := vdb.db.GetIterator(dataStartKey, dataEndKey)
+
+	// Wrap the iterator creation in a recover block
+	var dbItr iterator.Iterator
+	var err error
+
+	func() {
+		defer func() {
+			if r := recover(); r != nil {
+				err = fmt.Errorf("panic while creating iterator: %v", r)
+			}
+		}()
+		dbItr, err = vdb.db.GetIterator(dataStartKey, dataEndKey)
+	}()
+
 	if err != nil {
-		return nil, err
+		return nil, errors.WithMessage(err, "error getting iterator from db")
+	}
+
+	if dbItr == nil {
+		return nil, errors.New("nil iterator returned from db")
 	}
+
 	return newKVScanner(namespace, dbItr, pageSize), nil
 }
 

gossip/gossip/algo/pull.go

@@ -7,6 +7,8 @@ SPDX-License-Identifier: Apache-2.0
 package algo
 
 import (
+	"crypto/rand"
+	"encoding/binary"
 	"sync"
 	"sync/atomic"
 	"time"
@@ -319,10 +321,28 @@ func (engine *PullEngine) OnRes(items []string, nonce uint64) {
 }
 
 func (engine *PullEngine) newNONCE() uint64 {
-	n := uint64(0)
+	engine.lock.Lock()
+	defer engine.lock.Unlock()
+
+	maxAttempts := 1000000
+	for i := 0; i < maxAttempts; i++ {
+		n := util.RandomUInt64()
+		if n != 0 && !engine.outgoingNONCES.Exists(n) {
+			return n
+		}
+	}
+
+	// If we still couldn't generate a unique NONCE after max attempts,
+	// keep trying with crypto/rand until we find one
+	var n uint64
 	for {
-		n = util.RandomUInt64()
-		if !engine.outgoingNONCES.Exists(n) {
+		bytes := make([]byte, 8)
+		if _, err := rand.Read(bytes); err != nil {
+			// Fallback to time-based if crypto/rand fails
+			return uint64(time.Now().UnixNano())
+		}
+		n = binary.BigEndian.Uint64(bytes)
+		if n != 0 && !engine.outgoingNONCES.Exists(n) {
 			return n
 		}
 	}

gossip/util/misc.go

@@ -18,7 +18,10 @@ import (
 	"github.com/spf13/viper"
 )
 
-var r *rand.Rand
+var (
+	r      *rand.Rand
+	rMutex sync.Mutex
+)
 
 func init() { // do we really need this?
 	var seed [32]byte
@@ -187,6 +190,8 @@ func RandomInt(n int) int {
 // If we want a rand that's non-global and specific to gossip, we can
 // establish one. Otherwise this uses the process-global locking RNG.
 func RandomUInt64() uint64 {
+	rMutex.Lock()
+	defer rMutex.Unlock()
 	return r.Uint64()
 }