Estimate gas on pending block by default #8627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
macfarla
approved these changes
May 19, 2025
| @@ -8,6 +8,7 @@ | |||
| ### Additions and Improvements | |||
| - `--Xplugin-rocksdb-blockchain-blob-garbage-collection-enabled` Adds ability to enabled BlobDB GC for BLOCKCHAIN column family [#8599](https://github.com/hyperledger/besu/pull/8599) | |||
| - `--Xplugin-rocksdb-blob-garbage-collection-age-cutoff`, `--Xplugin-rocksdb-blob-garbage-collection-force-threshold` BlobDB GC config options [#8599](https://github.com/hyperledger/besu/pull/8599) | |||
| - Estimate gas on pending block by default [#8627](https://github.com/hyperledger/besu/pull/8627) | |||
There was a problem hiding this comment.
is there a use-case for needing the previous behavior? ie is this a breaking change for some segment of users?
There was a problem hiding this comment.
I do not think so, because this can be seen as the correct behavior, so kind of a bug fix
macfarla
added
the
doc-change-required
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
force-pushed
the
improve-estimate-gas1
branch
from
345a195 to
d34223c
Compare
alexandratran
removed
the
doc-change-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
First PR of a series that improve gas estimations.
When calling
eth_estimateGasis the block number or tag parameter is not present, then default topendinginstead oflatestto improve the accuracy, since the estimation if for inclusion in the next block.Comparing this PR with current main branch, using https://github.com/Consensys/compate-estimate-gas-plugin, there are less under estimations:
BesuNightly 11434
BesuPR8627 11276
more improvements will be part of following PRs
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests