-
Notifications
You must be signed in to change notification settings - Fork 929
storage proof key - use 0x0 for zero #8499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Note I had to update several I don't think this would be a breaking change - and we'll be now consistent with geth - but flagging for reviewers. |
Signed-off-by: Sally MacFarlane <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
This reverts commit 4d4024e. Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
@lu-pinto based on your feedback and further chat w Gary, adopted your suggestion to keep the leading zeros where we had them before. |
PR description
return 0x0 for zero key rather than 0x
Added a test for visibility
Fixed Issue(s)
related to #5377
related to rpc-compat hive tests
this fixes 1 hive test:
eth_getProof/get-account-proof-with-storage
Refs this comment 5cb6c26#r2017642440
This was discussed on RPC standards call and since odd-length hex strings are widely used we will stick with that. Quantity.create handles the zero edge case already.
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests