Skip to content

Improve BLOCKHASH Short Circuit #8171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Improve BLOCKHASH Short Circuit #8171

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
14d9b10
Improve BLOCKHASH Short Circuit
shemnon Jan 24, 2025
72e8578
docs
shemnon Jan 24, 2025
419fd33
Merge branch 'main' into blockhash-short-circuit
jflo Jan 29, 2025
4c53685
Merge branch 'main' into blockhash-short-circuit
garyschulte Jan 30, 2025
7f56bb5
Merge branch 'main' into blockhash-short-circuit
macfarla Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion evm/src/main/java/org/hyperledger/besu/evm/operation/BlockHashOperation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public OperationResult execute(final MessageFrame frame, final EVM evm) {

// If the current block is the genesis block or the sought block is
// not within the lookback window, zero is returned.
if (currentBlockNumber == 0
if (soughtBlock < 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment for this condition is no longer accurate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

|| soughtBlock >= currentBlockNumber
|| soughtBlock < (currentBlockNumber - blockHashLookup.getLookback())) {
frame.pushStackItem(Bytes32.ZERO);
Expand Down
Loading