cleanup: remove BoolTrue and BoolFalse variable #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abirdcfly <[email protected]>
jkneubuh
reviewed
Nov 4, 2022
| } | ||
|
|
||
| return false | ||
| return s.IsPrecreate != nil && *s.IsPrecreate |
Contributor
There was a problem hiding this comment.
This line is great - much clearer. Thanks for letting us know about the pointer package!
This line is much cleaner than the old function. No need to update the PR, but I wonder if using the BoolDeref() here would make the intent even clearer. E.g.:
return pointer.BoolDeref(s.IsPrecreate, false)
It would be really good to establish a common pattern for comparisons with maybe-null boolean attributes, and carry this forward.
jkneubuh
approved these changes
Nov 4, 2022
Contributor
jkneubuh
left a comment
jkneubuh
left a comment
There was a problem hiding this comment.
@Abirdcfly thanks for the nice clean-up. Very clear with the new code. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.