Add univa to models #1526
Add univa to models #1526
Conversation
merveenoyan
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c,
pcuenca and
ngxson
as code owners
| @@ -1027,6 +1027,14 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = { | |||
| countDownloads: `path_extension:"pt"`, | |||
| snippets: snippets.ultralytics, | |||
| }, | |||
| "univa": { | |||
There was a problem hiding this comment.
| "univa": { | |
| univa: { |
There was a problem hiding this comment.
LGTM! requires the tag to be merged on the hub before merge: https://huggingface.co/LanguageBind/UniWorld-V1/blob/main/README.md?code=true#L3
| @@ -1408,6 +1408,17 @@ model = SwarmFormerModel.from_pretrained("${model.id}") | |||
| `, | |||
| ]; | |||
|
|
|||
| export const univa = (model: ModelData): string[] => [ | |||
| `from univa.models.qwen2p5vl.modeling_univa_qwen2p5vl import UnivaQwen2p5VLForConditionalGeneration | |||
There was a problem hiding this comment.
| `from univa.models.qwen2p5vl.modeling_univa_qwen2p5vl import UnivaQwen2p5VLForConditionalGeneration | |
| `# Follow installation instructions at https://github.com/PKU-YuanGroup/UniWorld-V1 | |
| from univa.models.qwen2p5vl.modeling_univa_qwen2p5vl import UnivaQwen2p5VLForConditionalGeneration |
| "univa": { | ||
| prettyLabel: "univa", | ||
| repoName: "univa", |
There was a problem hiding this comment.
| "univa": { | |
| prettyLabel: "univa", | |
| repoName: "univa", | |
| "uniworld": { | |
| prettyLabel: "UniWorld", | |
| repoName: "UniWorld", |
Shouldn't the library be named UniWorld instead to follow the repo naming convention? I feel it would be more natural that way
| @@ -1027,6 +1027,14 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = { | |||
| countDownloads: `path_extension:"pt"`, | |||
| snippets: snippets.ultralytics, | |||
| }, | |||
| "univa": { | |||
There was a problem hiding this comment.
as mentioned by @Vaibhavs10 let's get the model listed under https://huggingface.co/models?other=uniworld (or https://huggingface.co/models?other=univa) before shipping this PR
| repoUrl: "https://github.com/PKU-YuanGroup/UniWorld-V1", | ||
| snippets: snippets.univa, | ||
| filter: true, | ||
| countDownloads: `path_extension:"safetensors"`, |
There was a problem hiding this comment.
Looks like the repo already have a config.json file so would be good to keep the counting on that file (if loaded at each .from_pretrained). This is the default rule if we don't set one.
Problem with counting path_extension:"safetensors" is that it's non-canonical + will count 17 downloads each time a user downloads the repo (given the 17 shards). (taken from files section)
@Vaibhavs10 @linoytsaban as discussed