-
Notifications
You must be signed in to change notification settings - Fork 6k
[WIP ] Add AnimateDiff SparseCntrl #6289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
# skip loading position embeddings | ||
adapter.load_state_dict(conv_state_dict, strict=False) | ||
adapter.save_pretrained(args.output_path) | ||
adapter.save_pretrained(args.output_path, variant="fp16") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For fp16 variant, we should also set the dtype to torch.float16
. I don't see that being used. This issue persists here too: https://huggingface.co/guoyww/animatediff-motion-adapter-v1-5-2/tree/main.
Both the fp16 and non-fp16 variants have the same size which shouldn't be the case.
Am I missing out on anything?
It seems that AnimateDiffSparseControlNetPipeline cannot be imported because nothing added in init.py. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
@DN6 Hey, what's holding this from merge? Happy to help if there's anything I can look into |
Hi @a-r-r-o-w sorry been a bit caught up with some other things. Feel free to take over this PR or open a new one if you prefer. The SparseControlNet needs to be cleaned up and we need to verify that the outputs match the original models. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
hello, is this WIP still in progress? i've tried to employ it as is and got some working controlnet-related results, but it worked per-frame (as usual non-sparse controlnet), not affecting the motion. that is, "controlled" (indexed) frames reproduced controlnet inputs while the rest was generated as if there was no controlnet at all. UPD: another glue is that setting |
Closing in favour of #8897 |
What does this PR do?
Add AnimateDiff SparseCntrl model to diffusers
https://github.com/guoyww/AnimateDiff/tree/main?tab=readme-ov-file#202312-animatediff-v3-and-sparsectrl
TODO:
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.