Clean up kernel mode syscall logging #8880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way they can be properly differentiated.
Collaborator
|
Thanks, it move torwards to #7965 |
| HLE_CLEAR_STACK_BYTES = 1 << 10 | ||
| HLE_CLEAR_STACK_BYTES = 1 << 10, | ||
| // Indicates that this call operates in kernel mode. | ||
| HLE_KERNEL_SYSCALL = 1 < 11, |
Contributor
There was a problem hiding this comment.
this was supposed to be so ?
Collaborator
Author
There was a problem hiding this comment.
Yes, this is the next bit up in the flag. 9, 10, 11.
Basically this is here because sceKernelCreateThread (and many other syscalls) has slightly different behavior when called through ThreadManForKernel, but not really different enough to justify creating an entirely separate function. Also, we could centrally check that the calling thread is in kernel mode for all applicable syscalls (we're not doing either yet, though.)
-[Unknown]
Collaborator
Author
There was a problem hiding this comment.
Oh, I didn't see that, yes.
-[Unknown]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just moves to using a flag so we know if we're in a kernel func or not, and logs a K in standard syscall logging.
If we did want to implement more kernel mode calls (e.g. for plugins or kernel-mode homebrew), this would make it more straight-forward to do so, too.
-[Unknown]