Add labels to all UI views #14202
Merged
Add labels to all UI views #14202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly marks several lists, which should make exposing text better.
Collaborator
Author
|
Okay, added lists and convenience describers for them. I don't think the describe functions for view groups would necessarily get called all that much for accessibility or search, but they seem pretty convenient for debugging. The semantics of have lists marked (compared to layout only) is useful, though. -[Unknown] |
Owner
|
Yeah, this seems like it could be useful. Sorry I kinda forgot about this one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point, does nothing with them. However, this can be used to facilitate search or even accessibility.
I've exposed descriptions that should largely make sense as accessibility hints, i.e. labeling headings, buttons, etc. Lists would be very nice but aren't specifically handled - considering a dedicated LinearLayout subclass.
-[Unknown]