Vulkan: Deal with the reformat clear better #12941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve due to the use of clear. Also instantly convert to a clear when binding the framebuffer in cases when we know it's the optimal thing. The QueueRunner would have later merged anyway hopefully, but I like the simplicity of this.
unknownbrackets
approved these changes
May 21, 2020
| draw_->Clear(Draw::FBChannel::FB_COLOR_BIT | Draw::FBChannel::FB_STENCIL_BIT, 0, 0.0f, 0); | ||
| // We have to bind here instead of clear, since it can be that no framebuffer is bound. | ||
| // The backend can sometimes directly optimize it to a clear. | ||
| draw_->BindFramebufferAsRenderTarget(vfb->fbo, { Draw::RPAction::CLEAR, Draw::RPAction::KEEP, Draw::RPAction::CLEAR }, "ReformatFramebuffer"); |
Collaborator
There was a problem hiding this comment.
It was reported somewhere that there can be bugs when depthAction != stencilAction in some drivers. Not sure how worried to be.
-[Unknown]
Owner
Author
There was a problem hiding this comment.
Right, but we might want to take care of that in the RenderManager instead in that case... Hm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out just doing a Clear doesn't work in GoW. So made the rendermanager convert to a clear if appropriate directly, instead of leaving it to the queuerunner to clean up - easier to tell what's going on. Also had to dirty some state, but I'll fix that in a better way in an upcoming commit.