GTA Vice City/Liberty City Stories and Shin Budokai 2 crashing issue while in Ad-hoc

What happens?

The game may crash while you someone hosts and join your game.
It could happen while you are playing PC versus PC or Android versus PC etc.
Here is a picture of when it happens :

Cant provide logs because it crashes lol.
Sometimes the game will work fine if someone else joins and you host or vice versa (at least on SB2).
I tried every setting I could "fast memory" and "I/O" and everything in System and so is the other guy so its not a setting issue.
Tried this online and not locally but I heard crashing issues might happen locally between different devices.

What should happen?

Game should work fine and not crash.

What are you using?

What hardware / device and operating system?

OS:Windows 10

What graphics card (GPU) or mobile phone model?

GPU: Radeon 530

What PPSSPP version (standalone/official), and did it work before?

v1.11.2-395-g0c40e918c and also tried stable 1.11.3
I am not sure I dont think it ever got fixed properly.

Which game or games?

ULUS10160
ULUS10234

Checklist

• [X ] Test in the latest git build in case it's already fixed.
• [ X] Search for other reports of the same issue.
• [X ] Try resetting settings or older versions and include if the issue is related.
• [ X] Include logs or screenshots of issue.

Maybe its related to this? #14172
And be a AdhocMatching issue.

[CAArmy]

The game does crash when joining host or when someone joins when creating host. Even with the correct IP address and ports, game immediately crashes when attempting to join others in adhoc. This issue must be resolved when possible. Thanks.

[anr2me]

Any step by step to reproduce this with a high chance locally/on LAN? if it's just occasionally happened it would be difficult to catch the exception, thus takes forever to fix.

Have you tried disabling Ignore bad memory access or may be disable JIT? it could at least not to crash PPSSPP if it was related to MIPS code, thus you can still see the Debug Console logs.

@mojojojodojo you can try running PPSSPP using DebugLog.bat or InfoLog.bat when reproducing this, it will at least generate some log.

I do remembered getting a crash on GTA VCS while running PPSSPP through VS Debugger, but it was because my Geforce (2gb vram) was running out of vram thus PPSSPP failed to allocate -_- not sure if there are memory leaks on vram or not, but i wasn't able to reproduce it again during my test.

PS: I do wished PPSSPP could dump some crash log whenever there is uncaught exceptions

PPS: Currently i don't even know the cause of bad memory access and stuck when selecting the English language on Patapon 3 (EU) :( while with 1.10.3 i can still progress by ignoring bad memory access, and the US version didn't have this issue.

Uploaded a log of SB2 while the Android player invites using DebugLog64.bat.
ppsspplog.zip
I think that the log implies its an AdhocMatching issue (?).
When the PC player invites the game works fine.
"Ignore bad memory access" was enabled/disabled for both but I didnt touch the JIT options.
Possibly its related to the GTA issue but I am not sure because there it also happens PC to PC (Windows) as well.
PS this is the best fighting game to play lag-wise and I didnt find a better fighting game that plays so well over the internet lol.

I reproduced the SB2 issue LAN wise by connencting the Android TV device that I have to my laptop and while the Android TV device invites.
PPSSPP will crash on the PC while the Android device will get a communication error.
I also managed to recreate the GTA issue while joining my Android TV hosted game and I will provide a log here:
ppsspplog.zip

So yeah the issue only happens from a certain side.
The PC to PC issue on GTA is rare to happen but also happens from time to time I guess.

To see if it's not an issue with my Android TV device I tried a 3rd game called MotoGP and that worked fine.
Here is another log for comparison:
ppsspplog.zip

[anr2me]

Well if the crash happened on Windows the issue should be on Windows side and not the Android one.

Based on the logs, it ended at
45:35:876 threadmain D[SCENET]: HLE\sceNetAdhoc.cpp:1485 sceNetAdhocPdpSend[1:1501]: Sent 5 bytes to 10.100.102.32:1501
And if it managed to print that out the next line is return 0 which exited the HLE, so the crash seems to happened after the game is calling sceNetAdhocPdpSend, not sure which HLE being used afterward.

I'll test it on my phone later when i had free space, my phone is currently acting strange :( no matter how many apps i uninstalled the storage will be full again after a few hours

I think you can also create a Linux/Android VM on your PC and connect it to the Windows PPSSPP instance.
Linux and Android got a similar networking code/stack I think and I had less issues there.
But take your time.

[anr2me]

My Laptop is also running out of space, sometimes building PPSSPP could drained my free space at C: to 0 bytes and the compiler is getting errors LOL

[anr2me]

Okay i was able to catch the exception, it happened when i tried to leave the game room on GTA VCS

It's happened on this weird looking for iteration where context->input_stack and msg is null and causing exception due to msg->next

ThreadMessage* msg = context->input_stack;
for (; msg != NULL; msg = msg->next)

I always wondered why there are people using for this way (it was part of the old code), personally i prefer using while for iterating linked list.

Edit: oops it was because i set msg manually to next at the end of the loop, without changing the for to while like i did on another part of the code.

I am not sure this is fixed yet... :S so dunno why its closed.