Remove deprecated API calls for new FFmpeg 4.3.x #14176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, modify it in case some packager was patching, so they see this.
No longer needed.
Contributor
|
Issue #13849 is fixed using this PR with ffmpeg git master as of today. https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/980b5c3bb5ffc94644d4e82f5bf98e5b83f932d7 |
Contributor
|
Issue #11490 is still instantly reproducible with the FMV in Tales of Eternia |
Collaborator
Author
|
Strange, it's only for some videos now... but it looks like another way is working in newer FFmpeg, trying it on some videos. -[Unknown] |
Contributor
|
I feel like these could enjoy a unit test or two. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses ifdefs to remove deprecated function / field usage, corrects
SetupStreams()usage on FFmpeg 3.1+.Should fix #11490 and probably #13849 (didn't try any unreleased versions.) May help #11278.
Note: at this point, no updates to any builds to use newer FFmpeg, so this would only affect those using system FFmpeg.
-[Unknown]