PPSSPP does not compile with ffmpeg-4.4

[sagitter]

Hi all.

What happens?

PPSSPP-1.10.3 does not compile against ffmpeg-4.4 (git commit 477dd2d):

[ 76%] Building CXX object CMakeFiles/Core.dir/Core/HW/MediaEngine.cpp.o
/usr/bin/g++ -DSDL -DSHARED_LIBZIP -DSHARED_ZLIB -DUSE_DISCORD=1 -DUSE_FFMPEG=1 -DVK_USE_PLATFORM_WAYLAND_KHR -DVK_USE_PLATFORM_XLIB_KHR -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE=1 -D_XOPEN_SOURCE=700 -D_XOPEN_SOURCE_EXTENDED -D__BSD_VISIBLE=1 -D__STDC_CONSTANT_MACROS -I/builddir/build/BUILD/ppsspp/ext/native -I/builddir/build/BUILD/ppsspp/ext/glslang -I/builddir/build/BUILD/ppsspp -I/builddir/build/BUILD/ppsspp/Common -I/builddir/build/BUILD/ppsspp/ext/cityhash -I/builddir/build/BUILD/ppsspp/ext/libkirk -I/builddir/build/BUILD/ppsspp/ext/sfmt19937 -I/builddir/build/BUILD/ppsspp/ext/xbrz -I/builddir/build/BUILD/ppsspp/ext/xxhash -I/builddir/build/BUILD/ppsspp/ext/glslang/glslang/.. -I/builddir/build/BUILD/ppsspp/ext/glslang/SPIRV/.. -I/builddir/build/BUILD/ppsspp/ext/SPIRV-Cross-build/../SPIRV-Cross -I/builddir/build/BUILD/ppsspp/ext/discord-rpc-build/../discord-rpc/src -I/builddir/build/BUILD/ppsspp/ext/discord-rpc-build/../discord-rpc/include -I/builddir/build/BUILD/ppsspp/ext/discord-rpc-build/../rapidjson/include -isystem /usr/include/SDL2 -isystem /usr/include/ffmpeg -O2  -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -DNDEBUG -O2 -D_NDEBUG   -Wno-multichar -msse2 -Wno-psabi -include /builddir/build/BUILD/ppsspp/ppsspp_config.h -fno-strict-aliasing -std=gnu++11 -o CMakeFiles/Core.dir/Core/HW/MediaEngine.cpp.o -c /builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp
In file included from /builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:24:
/builddir/build/BUILD/ppsspp/GPU/GPUState.h: In member function 'void GPUStateCache::SetCurRTOffsetX(int)':
/builddir/build/BUILD/ppsspp/GPU/GPUState.h:601:25: warning: comparison of integer expressions of different signedness: 'int' and 'u32' {aka 'unsigned int'} [-Wsign-compare]
  601 |                 if (off != curRTOffsetX) {
      |                     ~~~~^~~~~~~~~~~~~~~
/builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp: In member function 'bool MediaEngine::SetupStreams()':
/builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:269:33: error: 'AVStream' {aka 'struct AVStream'} has no member named 'request_probe'
  269 |                         stream->request_probe = 0;
      |                                 ^~~~~~~~~~~~~
/builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp: In member function 'bool MediaEngine::openContext(bool)':
/builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:322:54: warning: 'AVStream::codec' is deprecated [-Wdeprecated-declarations]
  322 |                         if(m_pFormatCtx->streams[i]->codec->codec_type == AVMEDIA_TYPE_VIDEO) {
      |                                                      ^~~~~
In file included from /builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:36:
/usr/include/ffmpeg/libavformat/avformat.h:884:21: note: declared here
  884 |     AVCodecContext *codec;
      |                     ^~~~~
/builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:322:54: warning: 'AVStream::codec' is deprecated [-Wdeprecated-declarations]
  322 |                         if(m_pFormatCtx->streams[i]->codec->codec_type == AVMEDIA_TYPE_VIDEO) {
      |                                                      ^~~~~
In file included from /builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:36:
/usr/include/ffmpeg/libavformat/avformat.h:884:21: note: declared here
  884 |     AVCodecContext *codec;
      |                     ^~~~~
/builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:322:54: warning: 'AVStream::codec' is deprecated [-Wdeprecated-declarations]
  322 |                         if(m_pFormatCtx->streams[i]->codec->codec_type == AVMEDIA_TYPE_VIDEO) {
      |                                                      ^~~~~
In file included from /builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:36:
/usr/include/ffmpeg/libavformat/avformat.h:884:21: note: declared here
  884 |     AVCodecContext *codec;
      |                     ^~~~~
/builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp: In member function 'bool MediaEngine::setVideoStream(int, bool)':
/builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:457:81: warning: 'AVStream::codec' is deprecated [-Wdeprecated-declarations]
  457 |                 AVCodecContext *m_pCodecCtx = m_pFormatCtx->streams[streamNum]->codec;
      |                                                                                 ^~~~~
In file included from /builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:36:
/usr/include/ffmpeg/libavformat/avformat.h:884:21: note: declared here
  884 |     AVCodecContext *codec;
      |                     ^~~~~
/builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:457:81: warning: 'AVStream::codec' is deprecated [-Wdeprecated-declarations]
  457 |                 AVCodecContext *m_pCodecCtx = m_pFormatCtx->streams[streamNum]->codec;
      |                                                                                 ^~~~~
In file included from /builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:36:
/usr/include/ffmpeg/libavformat/avformat.h:884:21: note: declared here
  884 |     AVCodecContext *codec;
      |                     ^~~~~
/builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:457:81: warning: 'AVStream::codec' is deprecated [-Wdeprecated-declarations]
  457 |                 AVCodecContext *m_pCodecCtx = m_pFormatCtx->streams[streamNum]->codec;
      |                                                                                 ^~~~~
In file included from /builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:36:
/usr/include/ffmpeg/libavformat/avformat.h:884:21: note: declared here
  884 |     AVCodecContext *codec;
      |                     ^~~~~
/builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp: In member function 'bool MediaEngine::stepVideo(int, bool)':
/builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:612:106: warning: 'int avcodec_decode_video2(AVCodecContext*, AVFrame*, int*, const AVPacket*)' is deprecated [-Wdeprecated-declarations]
  612 |                         int result = avcodec_decode_video2(m_pCodecCtx, m_pFrame, &frameFinished, &packet);
      |                                                                                                          ^
In file included from /builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:35:
/usr/include/ffmpeg/libavcodec/avcodec.h:3085:5: note: declared here
 3085 | int avcodec_decode_video2(AVCodecContext *avctx, AVFrame *picture,
      |     ^~~~~~~~~~~~~~~~~~~~~
/builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:627:80: warning: 'int64_t av_frame_get_best_effort_timestamp(const AVFrame*)' is deprecated [-Wdeprecated-declarations]
  627 |                                 if (av_frame_get_best_effort_timestamp(m_pFrame) != AV_NOPTS_VALUE)
      |                                                                                ^
In file included from /usr/include/ffmpeg/libavcodec/avcodec.h:38,
                 from /builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:35:
/usr/include/ffmpeg/libavutil/frame.h:702:9: note: declared here
  702 | int64_t av_frame_get_best_effort_timestamp(const AVFrame *frame);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:628:97: warning: 'int64_t av_frame_get_best_effort_timestamp(const AVFrame*)' is deprecated [-Wdeprecated-declarations]
  628 |                                         m_videopts = av_frame_get_best_effort_timestamp(m_pFrame) + av_frame_get_pkt_duration(m_pFrame) - m_firstTimeStamp;
      |                                                                                                 ^
In file included from /usr/include/ffmpeg/libavcodec/avcodec.h:38,
                 from /builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:35:
/usr/include/ffmpeg/libavutil/frame.h:702:9: note: declared here
  702 | int64_t av_frame_get_best_effort_timestamp(const AVFrame *frame);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:628:135: warning: 'int64_t av_frame_get_pkt_duration(const AVFrame*)' is deprecated [-Wdeprecated-declarations]
  628 |                                         m_videopts = av_frame_get_best_effort_timestamp(m_pFrame) + av_frame_get_pkt_duration(m_pFrame) - m_firstTimeStamp;
      |                                                                                                                                       ^
In file included from /usr/include/ffmpeg/libavcodec/avcodec.h:38,
                 from /builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:35:
/usr/include/ffmpeg/libavutil/frame.h:706:9: note: declared here
  706 | int64_t av_frame_get_pkt_duration         (const AVFrame *frame);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~
/builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:630:89: warning: 'int64_t av_frame_get_pkt_duration(const AVFrame*)' is deprecated [-Wdeprecated-declarations]
  630 |                                         m_videopts += av_frame_get_pkt_duration(m_pFrame);
      |                                                                                         ^
In file included from /usr/include/ffmpeg/libavcodec/avcodec.h:38,
                 from /builddir/build/BUILD/ppsspp/Core/HW/MediaEngine.cpp:35:
/usr/include/ffmpeg/libavutil/frame.h:706:9: note: declared here
  706 | int64_t av_frame_get_pkt_duration         (const AVFrame *frame);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/Core.dir/build.make:2334: CMakeFiles/Core.dir/Core/HW/MediaEngine.cpp.o] Error 1

What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.

Fedora 34 64bit (devel branch)
GCC-11.0.0

[iota97]

Seem that AVStream::request_probe was never supposed to be public as the documentation state: NOT PART OF PUBLIC API.

It's no longer exposed since: this.

About how to fix it I don't know the API well enough to know what that does exactly. Commenting that line out would make it compile again I guess, no idea if it might break something tho'. It's better to use PPSSPP FFMPEG if possible to avoid breakage in general.

[orbea]

It's better to use PPSSPP FFMPEG if possible to avoid breakage in general.

PPSSPP FFMPEG is a time bomb that will break sooner or later with some toolchain/userland update.

[hrydgard]

If it breaks we'll fix it. Don't see what's so time-bomby about a static chunk of code that we never update and doesn't really do any I/O.

[orbea]

Don't see what's so time-bomby about a static chunk of code that we never update and doesn't really do any I/O.

What do you expect from a large and complicated library that hasn't been updated in years and builds as one large warning with modern compilers? No offense intended, but you are kidding yourself if you think that keeping up to date with upstream ffmpeg would be more long term work than fixing years worth of bitrot in the PPSSPP ffmpeg fork.

[hrydgard]

builds as one large warning

brutal :)

I would love to get it to work but the reality is that there are always more critical things to take care of, and the current setup is still working. And every time we've tried, we've gotten very hard-to-debug breakage.

So, it'll happen once it becomes a critical issue. Right now it's not critical enough to compete for my attention with stuff like the looming Android storage hell in Android 12, for example.

[orbea]

Totally understandable. I just hope it can be fixed before both the current static binaries and the build breaks. I have seen the former happen before, but they were just rebuilt in those cases.

[sagitter]

builds as one large warning

brutal :)

I would love to get it to work but the reality is that there are always more critical things to take care of, and the current setup is still working. And every time we've tried, we've gotten very hard-to-debug breakage.

So, it'll happen once it becomes a critical issue. Right now it's not critical enough to compete for my attention with stuff like the looming Android storage hell in Android 12, for example.

When will PPSSPP be adjusted for using FFMpeg-4.4?
I need to know if i will be obliged to modify my PPSSPP build for using FFMpeg-ppsspp. Thanks.

[hrydgard]

Okay, I guess that's (hrydgard/ppsspp-ffmpeg#59) the time bomb triggering again for the precompiled ones, although it should be possible to just rebuild it as-is...

[orbea]

Yea, I have seen that happen a few times. Especially on 32-bit linux which is not tested as frequently. What I am more worried about is a system update that breaks the ppsspp-ffmpeg build or even the runtime which may not be noticed until a rebuild is needed.

[hrydgard]

Absolutely do agree with you that we need to address this, preferably sooner than later.

So I have a few different paths in mind. For linux and similar platforms, using the system ffmpeg would indeed be nice, and maybe it's not churning as much nowadays as it used to. So it might make sense to put in some work and see if we can bring it up on a modern ffmpeg sometime after the release of 1.11.

For other platforms that need to build it, I'm thinking it might make sense to ditch the precompiled executables and just integrate the build systems, so it's always built. Machines are faster now and the parts of ffmpeg that we need are just not that slow to build, so that would enable us to drastically reduce the download size of the ffmpeg repo...

Then there's the thing that nowadays many platforms have built-in h.264 decoders, but it would be a lot of error prone work to integrate system decoders...

Not really sure...

[unknownbrackets]

We'll always want FFmpeg for ATRAC3+, though, h.264 aside.

-[Unknown]

[hrydgard]

Well yeah of course, I just mean we could disable some decoders in the build. Didn't finish the thought properly heh.