Missing battle transition effect Valkyrie Profile Lenneth (Libretro)

[BParks21]

What happens?

Missing distorted battle transition effect.

What should happen?

When making contact with an enemy in the libretro core the distorted transition is missing it just freezes then goes black then to the battle. The battles are fine, everything becomes visible after the black screen. The effect is present and works fine in upstream. The first image is upstream the other two are from libretro.

What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.

i7 8086k, GTX 1080ti, Windows 10 desktop and the latest version of the core through the online updater.

[unknownbrackets]

This may be caused by missing settings or lack of dual source blending or similar.

If you turn off block transfers, buffered rendering, or enable "disable slow effects", can you trigger the same behavior in PPSSPP proper? That would point to a problem with how libretro handles or forces that setting.

-[Unknown]

[unknownbrackets]

Recently someone in Discord reported that libretro was not exposing GLES3 / OpenGL 3+ features to PPSSPP. On the same device, PPSSPP proper worked fine. That might be related to this issue.

-[Unknown]

[BParks21]

@unknownbrackets Strange i just discovered that enabling unsafe funreplacements fixes the effect, but why would disabling it break the effect. This doesn't happen when it's disabled in upstream.

[unknownbrackets]

While most games draw using the GPU, some games update drawing from the CPU. When using a hardware backend (i.e. not using software rendering), these effects won't normally be visible.

Func replacements (which includes hooks) are on by default in PPSSPP and there's normally no option to turn them off. These hook standard library functions to detect attempts to change graphics and update the hardware renderer.

I wouldn't be surprised if they're needed for this effect. If so, it probably means block transfer is needed too. I can't imagine why that'd be different in PPSSPP proper. I'm also not sure what "unsafe" refers to.

-[Unknown]

[BParks21]

Well both versions of ppsspp have this option and having it off in proper still allows the effect to render.
Edit: Wait it seems that the latest proper has removed the option completely. Possibly it was never there and I assumed it was.

[BParks21]

@hrydgard What is the upstream equivalent setting of Unsafe FuncReplacements from the libretro port. Because with it off in the core options the battle transition affects in Valkyrie Profile Lenneth are gone. With it on the battle transition affect is fine. Should this be set to on in the libretro core options?

[unknownbrackets]

That's not intended to be a user visible option, it's just in the ini for debugging.

-[Unknown]

[BParks21]

@unknownbrackets Why have it exposed as a core option in the libretro port then? Seems confusing to show something on called "unsafe"

[hrydgard]

It should be defaulted to true and not made visible as a user option. It's not that unsafe, we run with it by default in standalone PPSSPP.

[BParks21]

It should be defaulted to true and not made visible as a user option. It's not that unsafe, we run with it by default in standalone PPSSPP.

It is visible as a user option in libretro.

[hrydgard]

Yes, I'm saying it should not be! It'll cause confusion like this.

[BParks21]

Yes, I'm saying it should not be! It'll cause confusion like this.

Ahhh I see, i misunderstood.