Fix UART IRQ handling: Correct APIC configuration and interrupt acknowledgment

[Copilot]

Fixes critical issues preventing UART interrupts from working correctly in the A9N microkernel.

Problem

UART IRQ was not functioning due to three core issues:

1. APIC register calculation bug - Incorrect I/O APIC redirection table access when disabling interrupts
2. Insufficient interrupt acknowledgment - Simple interrupt handler that didn't properly identify and clear UART interrupt conditions
3. Missing UART IIR support - No support for reading the Interrupt Identification Register

Root Cause Analysis

The UART interrupt flow was broken at multiple points:

• IRQ 4 (COM1) is configured via io_apic_core.enable_interrupt(0x04) and maps to reserved_irq::CONSOLE_0 (0x24)
• The APIC disable_interrupt() function was accessing wrong register offsets
• The interrupt handler only read data without checking interrupt types or ensuring complete clearing

Changes

Fixed APIC Configuration Bug (apic.cpp)

// Before: Wrong register calculation
uint32_t io_apic_register = io_apic_register_index::REDIRECTION_TABLE + irq_number * 2;

// After: Correct calculation matching enable_interrupt()
uint32_t io_apic_register = io_apic_register_index::REDIRECTION_TABLE + real_irq_number * 2;

Enhanced UART Interrupt Handling (serial.cpp)

Added missing IIR register definition for proper UART interrupt identification:

inline constexpr uint16_t IIR = 2;

Improved UART IRQ Handler (interrupt.cpp)

Replaced simple data reading with comprehensive interrupt handling:

• Read IIR register to identify specific interrupt types
• Handle "Receive Data Available" interrupts (IIR & 0x06 == 0x04)
• Handle "Character Timeout" interrupts (IIR & 0x06 == 0x0C)
• Ensure all pending data is read to prevent buffer overflows
• Proper interrupt clearing per UART specifications

Verification

• IRQ mapping confirmed: IRQ 4 → Vector 0x24 (CONSOLE_0) ✓
• Syntax validated: All changes compile successfully
• Minimal impact: Only 3 files changed, 26 lines total modifications
• No breaking changes: Existing functionality preserved

Expected Result

UART interrupts should now work reliably with proper:

• APIC interrupt routing and management
• Interrupt type identification and acknowledgment
• Complete data reading and buffer management
• Enhanced debugging output for troubleshooting

These surgical fixes address the fundamental issues blocking UART IRQ functionality while maintaining the existing codebase architecture.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• esm.ubuntu.com
  • Triggering command: /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.