Skip to content

feat(cookie): add RFC 6265 compliant cookie deduplication #4576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luojiyin1987 wants to merge 7 commits into
base: main
Choose a base branch
from
+786 −54
Open

feat(cookie): add RFC 6265 compliant cookie deduplication #4576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
87cd162
feat(cookie): add RFC 6265 compliant cookie deduplication
luojiyin1987 Dec 13, 2025
22f4bfb
test(cookie): add tests for cookie deduplication
luojiyin1987 Dec 13, 2025
4f5a188
test(context): update cookie test to match RFC 6265 behavior
luojiyin1987 Dec 13, 2025
a091ebf
ci: apply automated fixes
autofix-ci[bot] Dec 14, 2025
aa065fd
test(cookie): add comprehensive tests for cookie deduplication
luojiyin1987 Dec 15, 2025
4759ce2
test(cookie): improve cookie deduplication test coverage
luojiyin1987 Dec 15, 2025
688c718
refactor(cookie): improve test utilities and fix race condition
luojiyin1987 Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/context.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,9 @@ describe('Pass a ResponseInit to respond methods', () => {
})
const res = c.body('', originalResponse)
const cookies = res.headers.getSetCookie()
expect(cookies.includes('context=1; Path=/')).toBe(true)
// Per RFC 6265, cookies with same name/domain/path should be deduped
// so only 'context=2' should remain (not 'context=1')
expect(cookies.includes('context=1; Path=/')).toBe(false)
expect(cookies.includes('context=2; Path=/')).toBe(true)
expect(cookies.includes('response=1; Path=/')).toBe(true)
})
Expand Down
Loading