docs(jwk): clarify what the JWK middleware validates #4545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the documentation to explain what validations happen automatically vs what developers need to handle themselves. Added some examples showing different use cases including custom claim validation. Fixes honojs#4542
Member
|
Thank you for the PR. I think we have to prioritize updating the website: https://hono.dev/docs/middleware/builtin/jwk , instead of adding a lot of description to JSDoc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the documentation to explain what validations happen automatically vs what developers need to handle themselves. Added some examples showing different use cases including custom claim validation.
Fixes #4542
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code