Allow middleware to redirect after downstream errors #4540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow middleware to override error responses by checking context.error in addition to isError flag. This enables middleware to handle errors gracefully (e.g., redirecting) even after the error handler has already set a response and finalized the context. Fixes honojs#4530
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4540 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 172 172
Lines 11221 11221
Branches 3255 3255
=======================================
Hits 10270 10270
Misses 950 950
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update compose so middleware can replace error responses when context.error is set, enabling patterns like c.redirect() after an error
add regression test covering the /hello?name=error scenario to ensure middleware can trigger a redirect post-error
captures the behavior reported in #4530 where redirects triggered in middleware were ignored after an error