Skip to content
This repository was archived by the owner on Feb 3, 2023. It is now read-only.

Conversation

@timotree3
Copy link
Collaborator

PR summary

Until either this PR is merged or TeXitoi/structopt#315 is fixed, all new CI runs will fail.

This PR

  • Mitigates the breakage introduced in structopt-derive v0.3.6 by preventing holochain_metrics from using that version of structopt-derive.
    • The way we prevent this is by adding an unused dependency of structopt-derive = "=0.3.3" to our Cargo.toml.

testing/benchmarking notes

N/A

followups

N/A

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

Copy link
Member

@zippy zippy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot! Fabulous catch. Thank you @timotree3

@zippy zippy merged commit c8e1751 into holochain:develop Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants