Added accounts filter #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuskendall
force-pushed
the
accounts_filter
branch
from
eae9406 to
85a0059
Compare
ray-kast
suggested changes
Jun 21, 2022
Comment on lines
+51
to
+54
| #[serde(default)] | ||
| pub owners: HashSet<String>, | ||
|
|
||
| #[serde(default)] |
Contributor
There was a problem hiding this comment.
Suggested change
| #[serde(default)] | |
| pub owners: HashSet<String>, | |
| #[serde(default)] | |
| pub owners: HashSet<String>, | |
I actually explicitly removed the #[serde(default)] attribute on most config keys because we ran into multiple issues previously with that attribute making typos in the config harder to detect.
Contributor
|
Superseded by #17. |
ray-kast
added a commit
that referenced
this pull request
Aug 16, 2022
Rebase of #5 (Added accounts filter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an (optional) filter to filter on individual accounts pubkeys.