Make scanlines and grille non-destructive #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@hiulit Just a reminder about this outstanding PR. |
Owner
|
Thanks! I'm sorry for the the late reply, I didn't see it. |
Owner
Author
|
In all my years on Github this was my first contribution. Very cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple adjustment, but this allows the developer to lower the opacity of the scanlines and grille without resulting in a completely black screen, which is exactly what I needed for Bodge Dall!
https://www.reddit.com/r/godot/comments/j0yk4r/spent_the_weekend_building_this_arcadestyle/g7ho26u/