Skip to content

Fix subscription accessor naming #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix subscription accessor naming #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/client/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,21 @@ export default class HgraphClient implements Client {
}

removeAllSubscriptions() {
this.getSubscribtions().forEach((observable) => observable.unsubscribe())
this.getSubscriptions().forEach((observable) => observable.unsubscribe())
}

getSubscribtions() {
getSubscriptions() {
//copy of original array
return [...this.subscriptions]
}

/**
* @deprecated Use {@link getSubscriptions} instead.
*/
getSubscribtions() {
return this.getSubscriptions()
}

subscribe(
flexibleRequestBody: FlexibleRequestBody,
handlers: SubscriptionHandlers
Expand Down
8 changes: 8 additions & 0 deletions src/types/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ export interface Client {
subscriptionClient: SubscriptionClient
removeSubscription: (subscription: ObservableSubscription) => void
removeAllSubscriptions: () => void
getSubscriptions: () => ObservableSubscription[]
/**
* @deprecated Use `getSubscriptions` instead.
*/
getSubscribtions: () => ObservableSubscription[]
query: <T>(
flexibleRequestBody: FlexibleRequestBody,
Expand All @@ -92,6 +96,10 @@ export default class HgraphClient implements Client {
private subscriptions: ObservableSubscription[]
removeSubscription: (subscription: ObservableSubscription) => void
removeAllSubscriptions: () => void
getSubscriptions: () => ObservableSubscription[]
/**
* @deprecated Use `getSubscriptions` instead.
*/
getSubscribtions: () => ObservableSubscription[]
query: <T>(
flexibleRequestBody: FlexibleRequestBody,
Expand Down