Fill dataset with budget terms #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, this method only does a shallow search of the budget. We really want to be able to fill every missing term in the budget!
Major changes: - The xarray dataset containing diagnostics is not passed to the xbudget functions so that derived terms can be (lazily) added to the dataset. The names of derived variables follow from the nested dictionary structure and are unambiguous. - dictionary structure has been modified so that the names of the new derived variables are also added to the dictionary. This facilitates evaluation of the reconstructed terms as it is now obvious if there are existing diagnostics that they should be equivalent to. - the collect_budgets function fills the budget with derived terms and the `aggregate` function is used to collect just some high-level terms To do: - Functions for more flexible grouping/aggregating/decomposing of budget terms. For example, what if someone wants a high-level budget for most terms but wants to really break down the surface fluxes as much as possible? They currently can do this manually by following the budget structure, but it would be nice to have helper functions to make it easier. - Support derived variables that are finite-differences of fluxes, to be compared against the flux-divergence diagnostics. - Somehow protect against users combining inconsistent terms (e.g. on different grids).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.